abi/bind: fix error-handling in generated wrappers for functions returning structs#22005
Merged
Merged
Conversation
connorwstein
requested review from
MariusVanDerWijden and
gballet
as code owners
MariusVanDerWijden
approved these changes
Dec 11, 2020
Member
MariusVanDerWijden
left a comment
MariusVanDerWijden
left a comment
There was a problem hiding this comment.
LGTM, thanks for noticing, and adding a test 👍
Contributor
Author
|
@MariusVanDerWijden thanks for the quick review. The build failure looks like a flake - would you be able to re-run? Don't think I have permissions to do that. |
Member
|
restarted |
holiman
changed the title
Contributor
|
Thanks! |
9 tasks
9 tasks
This was referenced Sep 23, 2022
9 tasks
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jan 24, 2025
…rning structs (ethereum#22005) Fixes the template used when generating code, which in some scenarios would lead to panic instead of returning an error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR the template was changed which ended up producing code like:
which will panic instead of returning an error if the contract doesn't exist. I moved the error handling up before the indexing to avoid that (analogous to how non-struct responses are handled)